Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: testing differents prompts #26

Merged
merged 2 commits into from
Nov 13, 2023
Merged

feat: testing differents prompts #26

merged 2 commits into from
Nov 13, 2023

Conversation

emanuel-braz
Copy link
Owner

No description provided.

@@ -233,7 +264,7 @@ async function main() {

const comments = await analyzeCode(filteredDiff, prDetails);
if (comments.length > 0) {
await createReviewComment(
createReviewOnPr(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'await' keyword is missing before the 'createReviewOnPr' function call. It should be added to ensure that the function is awaited before proceeding.

@@ -25,5 +25,4 @@ jobs:
exclude: "**/*.json, **/*.md, **/*.g.dart"
append_prompt: |
- Give a maximum of 4 suggestions
- Do not suggest code formatting issues.
- Do not suggest imports issues.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the line with the comment 'Do not suggest imports issues.' since it is not needed anymore.

@@ -233,7 +264,7 @@ async function main() {

const comments = await analyzeCode(filteredDiff, prDetails);
if (comments.length > 0) {
await createReviewComment(
createReviewOnPr(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing 'await' keyword before 'createReviewOnPr' function call.

@@ -25,5 +25,4 @@ jobs:
exclude: "**/*.json, **/*.md, **/*.g.dart"
append_prompt: |
- Give a maximum of 4 suggestions
- Do not suggest code formatting issues.
- Do not suggest imports issues.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the line with the comment 'Do not suggest imports issues.'

@@ -233,7 +264,7 @@ async function main() {

const comments = await analyzeCode(filteredDiff, prDetails);
if (comments.length > 0) {
await createReviewComment(
createReviewOnPr(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing 'await' keyword before 'createReviewOnPr' function call.

@emanuel-braz emanuel-braz merged commit 6f8a532 into master Nov 13, 2023
1 check passed
@emanuel-braz emanuel-braz deleted the prompts branch November 13, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant